TST: Refactor slow test #53610
Merged
TST: Refactor slow test #53610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Testing
| with tm.assert_produces_warning(FutureWarning, match=msg): | ||
| for i in range(1000): | ||
| len(algos.unique(lst)) | ||
| lst = np.array(["A", "B", "C", "D", "E"], dtype=object) |
There was a problem hiding this comment.
would this still catch the original refcount bug?
im guessing we'd get most of the performance improvement by passing check_stacklevel=False to assert_produces_warning
There was a problem hiding this comment.
Yeah looking back it appears this should have still happened if a numpy array is passed, so I think preemptively changing to address the FutureWarning too is OK
|
Going to merge since we have testing of this FutureWarning elsewhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went from 2s to 0.05s locally